Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/nodes #9

Merged
merged 5 commits into from
Nov 9, 2022
Merged

tests/nodes #9

merged 5 commits into from
Nov 9, 2022

Conversation

erexer
Copy link
Collaborator

@erexer erexer commented Oct 24, 2022

change nodes.py to be consistent for multiples of 45 degrees, add a test for orientation_to_neighbor

@erexer erexer requested a review from crvernon October 24, 2022 18:38
Copy link
Collaborator

@crvernon crvernon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on these @erexer! Just a few minor things...

naturf/tests/test_nodes.py Outdated Show resolved Hide resolved
naturf/tests/test_nodes.py Outdated Show resolved Hide resolved
@crvernon
Copy link
Collaborator

crvernon commented Nov 3, 2022

Your tests are failing on a dependency install. Can you get that working before you merge? I’ll go ahead and approve. Feel free to merge once the tests pass.

@erexer erexer merged commit 0fd2026 into feature/nodes Nov 9, 2022
@erexer erexer deleted the tests/nodes branch November 9, 2022 16:45
@erexer erexer restored the tests/nodes branch November 9, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants