Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the used port 8080 #219

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Expose the used port 8080 #219

merged 1 commit into from
Feb 10, 2021

Conversation

nightscape
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #219 (06314dc) into master (6c8a53b) will increase coverage by 0.04%.
The diff coverage is 78.86%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #219      +/-   ##
============================================
+ Coverage     65.69%   65.73%   +0.04%     
- Complexity     3237     3259      +22     
============================================
  Files           284      284              
  Lines         14522    14553      +31     
  Branches       1926     1937      +11     
============================================
+ Hits           9540     9567      +27     
- Misses         4231     4233       +2     
- Partials        751      753       +2     
Impacted Files Coverage Δ Complexity Δ
...d/snowstorm/core/data/services/ConceptService.java 87.12% <33.33%> (-0.41%) 116.00 <1.00> (+1.00) ⬇️
.../snomed/snowstorm/fhir/domain/ValueSetWrapper.java 61.90% <50.00%> (ø) 6.00 <1.00> (ø)
...omed/snowstorm/core/data/domain/ConcreteValue.java 68.42% <71.15%> (-3.32%) 16.00 <14.00> (+7.00) ⬇️
...services/classification/ClassificationService.java 42.85% <71.42%> (+0.15%) 36.00 <0.00> (ø)
...nowstorm/ecl/domain/refinement/AttributeRange.java 86.66% <82.35%> (-8.58%) 27.00 <19.00> (+12.00) ⬇️
...nomed/snowstorm/core/data/domain/Relationship.java 89.75% <100.00%> (+0.66%) 86.00 <1.00> (+2.00)
...orm/core/data/services/AxiomConversionService.java 95.55% <100.00%> (ø) 22.00 <0.00> (ø)
...snowstorm/ecl/domain/refinement/SEclAttribute.java 91.62% <100.00%> (+1.19%) 63.00 <2.00> (-3.00) ⬆️
...org/snomed/snowstorm/fhir/services/FHIRHelper.java 32.14% <0.00%> (-0.80%) 45.00% <0.00%> (-1.00%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 998c44a...06314dc. Read the comment docs.

Copy link
Member

@kaicode kaicode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, this prevents the need to expose the default port manually.

@kaicode kaicode merged commit 992c31c into IHTSDO:master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants