Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concept search "returnIdOnly" format must use quoted ids to avoid javascript precision issue #367

Closed
kaicode opened this issue Jan 31, 2022 · 1 comment
Closed

Concept search "returnIdOnly" format must use quoted ids to avoid javascript precision issue #367

kaicode opened this issue Jan 31, 2022 · 1 comment
Assignees
@kaicode
Labels
bug fixed-in-dev

Comments

@kaicode
Copy link
Member

kaicode commented Jan 31, 2022 •
edited
Loading

Concept ids that are 18 characters long get rounded when put into JSON as a number.
For example "450229981000132104" is rounded to "450229981000132100".. the last two digits get changed to 0.

Snowstorm should always return SCTIDs as quoted Strings to avoid this problem. The concept search is not currently doing this when the returnIdOnly parameter is used. Running a search that matches concept "450229981000132104" returns an identifier of "450229981000132104" in the response. This is a bug.

https://snowstorm.ihtsdotools.org/snowstorm/snomed-ct/MAIN/concepts?conceptIds=450229981000132104&returnIdOnly=true
Screenshot 2022-01-31 at 15 37 39
@kaicode kaicode added the bug label Jan 31, 2022
kaicode added a commit that referenced this issue Jan 31, 2022
@kaicode
Fixes #367 return concept ids as strings when returnIdOnly param used.
e2c65b8
pgwilliams pushed a commit that referenced this issue Jan 31, 2022
@kaicode @pgwilliams
Fixes #367 return concept ids as strings when returnIdOnly param used.
cfd4e9d
pgwilliams pushed a commit that referenced this issue Jan 31, 2022
@kaicode @pgwilliams
INFRA-8308 Fixes #367 return concept ids as strings when returnIdOnly…
f24595b 
… param used.
CoderMChu pushed a commit that referenced this issue Feb 14, 2022
@kaicode @CoderMChu
INFRA-8308 Fixes #367 return concept ids as strings when returnIdOnly…
ee2644e 
… param used.
@kaicode
Copy link
Member Author

kaicode commented Mar 21, 2022

Fixed in release 7.7.0.

@kaicode kaicode self-assigned this Mar 21, 2022
njmarques pushed a commit to WestCoastInformatics/snowstorm-1 that referenced this issue Jun 16, 2023
@njmarques
INFRA-8308 Fixes IHTSDO#367 return concept ids as strings when return…
e077cc2 
…IdOnly param used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaicode kaicode

Labels
bug fixed-in-dev
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kaicode