Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas deprecation for series call #117

Merged
merged 2 commits into from
May 31, 2024

Conversation

agarciadiego
Copy link
Contributor

@agarciadiego agarciadiego commented May 21, 2024

Removes FutureWarning deprecation message on parmest notebooks on how the elements of the dataframe/dictionary are indexed

Fixes #108

{Description}
Changes the way of calling the data and differentiates between a dictionary and a dataframe. Based on parmest examples in Pyomo repo

Replaces #110

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

📚 Documentation preview 📚: https://idaes-examples--117.org.readthedocs.build/en/117/

@agarciadiego agarciadiego self-assigned this May 21, 2024
@agarciadiego agarciadiego added the Priority:Normal Normal Priority Issue or PR label May 21, 2024
@agarciadiego agarciadiego requested a review from MarcusHolly May 30, 2024 19:07
Copy link
Contributor

@MarcusHolly MarcusHolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'm not exactly sure what the "pr" stands for in parameter_estimation_pr.ipynb. Is it an abbreviation of property?

@agarciadiego
Copy link
Contributor Author

LGTM, although I'm not exactly sure what the "pr" stands for in parameter_estimation_pr.ipynb. Is it an abbreviation of property?

Peng-Robinson

@lbianchi-lbl lbianchi-lbl merged commit f88cbd5 into IDAES:main May 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pandas deprecation warnings in parameters estimation notebooks
4 participants