Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic666 input haspopup invalid help #719

Merged
merged 17 commits into from
Mar 2, 2022

Conversation

philljenkins
Copy link
Contributor

Reviewing, approving, and merging this PR should close #707

@philljenkins
Copy link
Contributor Author

philljenkins commented Mar 1, 2022

@shunguoy Karma and Mocha are set to:
INFORMATION - FAIL
while the testcase is set to:
VIOLATION - POTENTIAL

I think the config files need to change to match in order to pass the build checks

@shunguoy
Copy link
Contributor

shunguoy commented Mar 1, 2022

@philljenkins on Karma and Mocha are set to:

INFORMATION - FAIL
while the testcase is set to:
VIOLATION - POTENTIAL

I thought once the level is set up in the rule message https://github.com/IBMa/equal-access/blob/dev-608/accessibility-checker-engine/src/v2/checker/accessibility/nls/index.ts. and in the ruleset https://github.com/IBMa/equal-access/blob/dev-608/accessibility-checker-engine/src/v2/checker/accessibility/rulesets/index.ts, the mapping in the reports of various tools are already there and we don't need to change. The levels in the test cases are picked from the rule messages. is it correct?

@shunguoy
Copy link
Contributor

shunguoy commented Mar 1, 2022

@philljenkins is this ready for QA now?

@ErickRenteria ErickRenteria merged commit 7cbdd52 into master Mar 2, 2022
@shunguoy shunguoy deleted the epic666-input-haspopup-invalid-help branch April 5, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants