-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rule: group_withInputs_hasName #642
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utation as well here to include legends and the for attribute in the computation.
This was referenced Jan 27, 2022
Added messages, why, what to do, and who it affects
edits to the ruleset file to add the new rule group_withInputs_hasName under sets IBM, WCAG 21, & WCAG20 and under requirements 1.3.1 & 3.3.2 in each set.
updated help from review comments by @snidersd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed code, messages, and help
Dependet on the completion of PR #646 merge both these to master at the same time. |
…a/equal-access into ali-group_withInputs_hasName
philljenkins
previously approved these changes
Feb 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ErickRenteria
previously approved these changes
Feb 3, 2022
ErickRenteria
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial Draft PR for new rule. With working rule code, messages, and help.
Todo:
Resolves #604 [Rule Help]
Resolves #622 [Rule Imp}
Resolves #660 [Rule Review]
Resolves #659 Epic for this rule