Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule: group_withInputs_hasName #642

Merged
merged 30 commits into from
Feb 4, 2022
Merged

Conversation

aliunwala
Copy link
Contributor

@aliunwala aliunwala commented Jan 26, 2022

Initial Draft PR for new rule. With working rule code, messages, and help.

Todo:

  • Verify messages are correct
  • Verify rule is in right rulesets with right severity and correct Requirement(s)
  • Update help file from @philljenkins branch
  • SME's confirm test cases look accurate
  • Review comments resolved and implemented in the PR

Resolves #604 [Rule Help]
Resolves #622 [Rule Imp}
Resolves #660 [Rule Review]
Resolves #659 Epic for this rule

@aliunwala aliunwala marked this pull request as draft January 26, 2022 13:59
philljenkins and others added 5 commits January 27, 2022 17:26
Added messages, why, what to do, and who it affects
edits to the ruleset file to add the new rule group_withInputs_hasName under sets IBM, WCAG 21, & WCAG20
and under requirements 1.3.1 & 3.3.2 in each set.
Copy link
Contributor

@philljenkins philljenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed code, messages, and help

@aliunwala
Copy link
Contributor Author

Dependet on the completion of PR #646 merge both these to master at the same time.

@ErickRenteria ErickRenteria marked this pull request as ready for review January 31, 2022 16:48
@philljenkins philljenkins requested review from philljenkins and removed request for ErickRenteria February 1, 2022 20:24
philljenkins
philljenkins previously approved these changes Feb 1, 2022
Copy link
Contributor

@philljenkins philljenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed final results are correct, checked local build and tested on local build for formatting erros to be fixed.
image

ErickRenteria
ErickRenteria previously approved these changes Feb 3, 2022
@ErickRenteria ErickRenteria merged commit e1e43d2 into master Feb 4, 2022
@ErickRenteria ErickRenteria deleted the ali-group_withInputs_hasName branch March 3, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment