Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

338 - Show invalid roles in invalid role message #586

Merged
merged 3 commits into from
Jan 7, 2022
Merged

338 - Show invalid roles in invalid role message #586

merged 3 commits into from
Jan 7, 2022

Conversation

tombrunet
Copy link
Member

@tombrunet tombrunet commented Dec 16, 2021 •
edited by carmacleod
Loading

Fixes #338

@tombrunet tombrunet mentioned this pull request Dec 16, 2021
Closed
@tombrunet tombrunet changed the title Issue 338 338 - Show invalid roles in invalid role message Dec 17, 2021
carmacleod
carmacleod approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@carmacleod carmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@tombrunet tombrunet added the engine Issues in the accessibility-checker-engine component label Jan 7, 2022
@tombrunet tombrunet merged commit 609385b into master Jan 7, 2022
@tombrunet tombrunet deleted the issue-338 branch January 7, 2022 22:10
@tombrunet
Copy link
Member Author

Pushing to preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmacleod carmacleod carmacleod approved these changes

@philljenkins philljenkins Awaiting requested review from philljenkins

Assignees
No one assigned
Labels
engine Issues in the accessibility-checker-engine component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error message in Assessment panel for input type=hidden is incorrect
2 participants
@tombrunet @carmacleod