Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrule(element_scrollable_tabbable, label_name_visible): fix issues related to off-screen and scrollable content #1964

Merged
merged 6 commits into from
Aug 14, 2024

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Jul 29, 2024

  • Rule bug: element_scrollable_tabbable, label_name_visible

This PR is related to the following issue(s):

Fixes #1911
Fixes #1889

Testing reference:

-for #1911: test/v2/checker/accessibility/rules/element_scrollable_tabbable_ruleunit/textarea_pass.html
The fixed violation: "The scrollable element <textarea> with non-interactive content is not tabbable"
-for #1889: test/v2/checker/accessibility/rules/label_name_visible_ruleunit/label_offscreen.html
One of the two violations is fixed (another is a correct reporting): "Accessible name does not match or contain the visible label text "

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@shunguoy shunguoy changed the title fixrule(element_scrollable_tabbable, label_name_visible): fix issues related off-screen and scrollable content fixrule(element_scrollable_tabbable, label_name_visible): fix issues related to off-screen and scrollable content Jul 31, 2024
@shunguoy shunguoy requested a review from tombrunet August 1, 2024 15:12
@shunguoy shunguoy marked this pull request as ready for review August 1, 2024 15:12
@ErickRenteria
Copy link
Contributor

Validated
Screenshot 2024-08-14 at 9 49 37 AM
Screenshot 2024-08-14 at 9 56 54 AM

@ErickRenteria ErickRenteria merged commit 50c6dfc into master Aug 14, 2024
15 checks passed
@tombrunet tombrunet deleted the dev-1911 branch January 8, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants