-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixrule(a_text_purpose, meta_viewport_zoomable
, widget_tabbable_exists
, widget_tabbable_single
): Re-mapping WCAG SC and help references
#1899
Conversation
@philljenkins I reviewed your changes. Please go ahead to review the rest and push to test. |
a_text_purpose, meta_viewport_zoomable
): Re-mapping WCAG SCa_text_purpose, meta_viewport_zoomable
, widget_tabbable_exists
, widget_tabbable_single
): Re-mapping WCAG SC and help references
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed code changes
Reviewed mapping changes are correct in Action artifact Rule listing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes and mapping reviewed and ready for QA
@shunguoy we also need to remove the requirements under why is this important? |
@ErickRenteria fixed, thanks. |
Rule/Engine updates:
fixrule(
a_text_purpose, meta_viewport_zoomable
): Re-mapping WCAG SCThis PR is related to the following issue(s):
Additional information can be found here:
Testing reference:
Click "Learn More" for Recommendation Message: Confirm the 'meta[name=viewport]' with "maximum-scale=1.0" can be zoomed by user
widget_tabbable_single
ruleI have conducted the following for this PR: