-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(extension|node|karma|cypress): Properly close the embedded browser #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shunguoy
changed the title
fix(engine): Properly close the engine #1837
fix(engine): Properly close the engine
Apr 10, 2024
shunguoy
changed the title
fix(engine): Properly close the engine
fix(extension|node|karma|cypress): Properly close the embedded browser
Apr 10, 2024
tombrunet
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following formats should be used for the release notes and PRs.
**Tool updates:
fix(extension|node|karma|cypress): Properly close the embedded browser
Please review more info: https://github.com/IBMa/equal-access/wiki/Release-notes -->
This PR is related to the following issue(s):
fixes: #1837
Testing reference:
I have conducted the following for this PR: