Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrule(list_markup_review) Reduce Needs Review false positives for a list #1861

Merged
merged 16 commits into from
Mar 7, 2024

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Mar 4, 2024

The following formats should be use for the release notes and PRs.

fixrule(list_markup_review) Reduce Needs Review false positives for list

  • Rule bug: list_markup_review

This PR is related to the following issue(s):

#1626

Testing reference:

test case: test/v2/checker/accessibility/rules/list_markup_review_ruleunit/list-widget-inapplicable.html
filter to the requirement 1.3.1 Info and Relationships
Before: two NR messages: Verify whether this is a list that should use HTML list elements
after: the two NR should disappear.

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • [] This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@shunguoy shunguoy requested a review from tombrunet March 6, 2024 15:47
@shunguoy shunguoy marked this pull request as ready for review March 6, 2024 15:47
@shunguoy shunguoy changed the title fixrule(list_markup_review) Reduce Needs Review false positives for list fixrule(list_markup_review) Reduce Needs Review false positives for a list Mar 6, 2024
@ErickRenteria
Copy link
Contributor

Validated
Screenshot 2024-03-06 at 10 14 40 PM

@ErickRenteria ErickRenteria added this pull request to the merge queue Mar 7, 2024
Merged via the queue into master with commit 565f70c Mar 7, 2024
15 checks passed
@shunguoy shunguoy deleted the dev-1626 branch March 11, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants