-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixrule(list_markup_review
) Reduce Needs Review false positives for a list
#1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syn dev branch dev-1641 with dev-1626
shunguoy
changed the title
fixrule(
fixrule(Mar 6, 2024
list_markup_review
) Reduce Needs Review false positives for listlist_markup_review
) Reduce Needs Review false positives for a list
tombrunet
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following formats should be use for the release notes and PRs.
fixrule(
list_markup_review
) Reduce Needs Review false positives for listThis PR is related to the following issue(s):
#1626
Testing reference:
test case: test/v2/checker/accessibility/rules/list_markup_review_ruleunit/list-widget-inapplicable.html
filter to the requirement 1.3.1 Info and Relationships
Before: two NR messages: Verify whether this is a list that should use HTML list elements
after: the two NR should disappear.
I have conducted the following for this PR: