fixrule(text_sensory_misuse
): Reduce "Needs Review" false positives for sensory text
#1855
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixrule(
text_sensory_misuse
): Reduce "Needs Review" false positives for the rulePlease review more info: https://github.com/IBMa/equal-access/wiki/Release-notes -->
This PR is related to the following issue(s):
#1641
Additional information can be found here:
Testing reference:
1.3.3 Sensory Characteristics:
first test case: test/v2/checker/accessibility/rules/text_sensory_misuse_ruleunit/Content-notSensory-hidden.html
before fix: 1 message: "If the word(s) 'round, square, shape, rectangle, triangle, right, left, top-left, top-right, bottom-right, bottom-left, above, below, top, bottom, upper, lower, corner, beside' is part of instructions for using page content, check it is still understandable without this location or shape information"
after fix: 2 messages: "Confirm the word(s) 'right, left, top-left, top-right, bottom-right, bottom-left, above, below, top, bottom, upper, lower, corner, beside' of the user instruction is used to indicate a logical rather than visual position"
and "Confirm the user instruction is still understandable without the word(s) 'round, square, shape, rectangle, triangle'"
Second test case: test/v2/checker/accessibility/rules/text_sensory_misuse_ruleunit/right-click.html
before fix: 2 messages
after fix: 1 message
I have conducted the following for this PR: