Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrule(aria_activedescendant_tabindex_valid): Required tab stop for aria-activedescendant="" should not fire #1690

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

shunguoy
Copy link
Contributor

Rule bug: aria_activedescendant_tabindex_valid

This PR is related to the following issue(s):

#1539

Additional information can be found here:

Testing reference:

test/v2/checker/accessibility/rules/aria_activedescendant_tabindex_valid_ruleunit/activedescendant_blank_tabbable.html
With the fix, the following violation should be gone: The element using 'aria-activedescendant' set to "" is not tabbable

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@shunguoy shunguoy requested a review from tombrunet September 25, 2023 18:38
@shunguoy shunguoy marked this pull request as ready for review September 25, 2023 18:38
@ErickRenteria
Copy link
Contributor

Validated

@ErickRenteria ErickRenteria merged commit 5afdd61 into master Sep 26, 2023
@shunguoy shunguoy deleted the dev-1539 branch September 29, 2023 14:19
@philljenkins philljenkins changed the title fixrule<aria_activedescendant_tabindex_valid>:required tab stop for aria-activedescendant="" should not fire fixrule(aria_activedescendant_tabindex_valid): Required tab stop for aria-activedescendant="" should not fire Nov 8, 2023
@philljenkins philljenkins changed the title fixrule(aria_activedescendant_tabindex_valid): Required tab stop for aria-activedescendant="" should not fire fixrule(aria_activedescendant_tabindex_valid): Required tab stop for aria-activedescendant="" should not fire Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants