Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): turn off the "emoticons_alt_exists" and "asciiart_alt_exists" rules #1658

Merged
merged 3 commits into from
Sep 19, 2023
Merged

fix(engine): turn off the "emoticons_alt_exists" and "asciiart_alt_exists" rules #1658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c17b3d8
disable rules #805
shunguoy Sep 8, 2023
7c584f5
update the baselines #805
shunguoy Sep 8, 2023
e16230b
Merge branch 'master' into dev-805
ErickRenteria Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions accessibility-checker-engine/src/v4/rules/asciiart_alt_exists.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,16 @@ export let asciiart_alt_exists: Rule = {
"group": "ASCII art must have a text alternative"
}
},
/**
* Decision in planning 9/7/23 that this rule causes more reviews that we see actual problems in content, so turn these rules off
rulesets: [{
"id": ["IBM_Accessibility", "WCAG_2_1", "WCAG_2_0"],
"num": ["1.1.1"],
"level": eRulePolicy.VIOLATION,
"toolkitLevel": eToolkitLevel.LEVEL_ONE
}],
*/
rulesets: [],
act: [],
run: (context: RuleContext, options?: {}, contextHierarchies?: RuleContextHierarchy): RuleResult | RuleResult[] => {
const ruleContext = context["dom"].node as Element;
Expand Down
5 changes: 5 additions & 0 deletions accessibility-checker-engine/src/v4/rules/emoticons_alt_exists.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,17 @@ export let emoticons_alt_exists: Rule = {
"group": "Emoticons must have a short text alternative that describes their purpose"
}
},
/**
* Decision in planning 9/7/23 that this rule causes more reviews that we see actual problems in content, so turn these rules off

rulesets: [{
"id": ["IBM_Accessibility", "WCAG_2_1", "WCAG_2_0"],
"num": ["1.1.1"],
"level": eRulePolicy.VIOLATION,
"toolkitLevel": eToolkitLevel.LEVEL_TWO
}],
*/
rulesets: [],
act: [],
run: (context: RuleContext, options?: {}, contextHierarchies?: RuleContextHierarchy): RuleResult | RuleResult[] => {
const validateParams = {
Expand Down
Loading