-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(engine): update roles for summary and li elements per ARIA in HTML spec change #1413
Conversation
@shunguoy unable to validate, test files do not exist in branch dev-1304: |
Validated aria_semantics_role |
@ErickRenteria the test case is correct. This PR fixes a false positive that shows up in the original one (first screenshot) and has a “The ARIA role ‘button’ is not valid for the element The test/v2/checker/accessibility/rules/aria_semantics_role_ruleunit/summary_element.html contains the test for the aria_hidden_nontabbable and aria_hidden_focus_misuse cases though not in the rule test folder. |
Validated |
Rule bug: aria_semantics_role, aria_hidden_focus_misuse
This PR is related to the following issue(s):
#1301 #824
Additional information can be found here:
Testing reference:
note that this branch was merged with the branch dev-1304 in PR #1432. The test should be done using the branch dev-1304 and with the following test cases.
For #1301 test/v2/checker/accessibility/rules/aria_semantics_role_ruleunit/summary_element.html
for #824 test/v2/checker/accessibility/rules/aria_semantics_role_ruleunit/li_element.html
I have conducted the following for this PR: