Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): update roles for summary and li elements per ARIA in HTML spec change #1413

Merged
merged 7 commits into from
May 15, 2023

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Apr 25, 2023

Rule bug: aria_semantics_role, aria_hidden_focus_misuse

This PR is related to the following issue(s):

#1301 #824

Additional information can be found here:

Testing reference:

note that this branch was merged with the branch dev-1304 in PR #1432. The test should be done using the branch dev-1304 and with the following test cases.

For #1301 test/v2/checker/accessibility/rules/aria_semantics_role_ruleunit/summary_element.html
for #824 test/v2/checker/accessibility/rules/aria_semantics_role_ruleunit/li_element.html

I have conducted the following for this PR:

  • [x ] I validated this code in Chrome and FF
  • [x ] I validated this fix in my local env
  • [x ] I provided details for testing
  • This PR has been reviewed and is ready for test
  • [x ] I understand that the title of this PR will be used for the next release notes.

@shunguoy shunguoy changed the title fix(engine): update roles for summary and li elements per ARIA in HTML change fix(engine): update roles for summary and li elements per ARIA in HTML spec change May 2, 2023
@shunguoy shunguoy requested a review from tombrunet May 4, 2023 15:07
@shunguoy shunguoy marked this pull request as ready for review May 4, 2023 15:07
tombrunet
tombrunet previously approved these changes May 5, 2023
@ErickRenteria
Copy link
Contributor

ErickRenteria commented May 12, 2023

@shunguoy unable to validate, test files do not exist in branch dev-1304:
test/v2/checker/accessibility/rules/aria_semantics_role_ruleunit/summary_element.html
test/v2/checker/accessibility/rules/aria_semantics_role_ruleunit/li_element.html
Screenshot 2023-05-12 at 12 59 03 PM

@ErickRenteria
Copy link
Contributor

Validated aria_semantics_role
Rule aria_hidden_nontabbable aka aria_hidden_focus_misuse does not have a failed test case. Hold in push

@shunguoy
Copy link
Contributor Author

shunguoy commented May 12, 2023

@ErickRenteria the test case is correct. This PR fixes a false positive that shows up in the original one (first screenshot) and has a “The ARIA role ‘button’ is not valid for the element

  • “, once it's fixed (second screenshot), the error is gone. No need for a failure case.
    Screenshot 2023-05-12 at 3 14 39 PM
    Screenshot 2023-05-12 at 3 15 35 PM

    The test/v2/checker/accessibility/rules/aria_semantics_role_ruleunit/summary_element.html contains the test for the aria_hidden_nontabbable and aria_hidden_focus_misuse cases though not in the rule test folder.

  • @ErickRenteria
    Copy link
    Contributor

    Validated

    @ErickRenteria ErickRenteria merged commit 0ee725c into master May 15, 2023
    @shunguoy shunguoy deleted the dev-1301 branch August 11, 2023 16:30
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants