Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(engine): fix bound issues with page scroll #1390

Merged
merged 4 commits into from
Apr 20, 2023
Merged

fix(engine): fix bound issues with page scroll #1390

merged 4 commits into from
Apr 20, 2023

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Apr 12, 2023 •
edited
Loading

  • Rule bug: element_tabbable_visible

This PR is related to the following issue(s):

Additional information can be found here:

Testing reference:

https://altoro-mutual.mybluemix.net/

  1. scroll the page down
  2. run the checker
  3. start the KMC
  4. observe the drawing of the navigation path to see any false positive on off-screen

please also look at #1163

I have conducted the following for this PR:

  • [ x] I validated this code in Chrome and FF
  • [x ] I validated this fix in my local env
  • [ x] I provided details for testing
  • This PR has been reviewed and is ready for test
  • [ x] I understand that the title of this PR will be used for the next release notes.

@shunguoy shunguoy requested a review from tombrunet April 13, 2023 02:27
@shunguoy shunguoy marked this pull request as ready for review April 13, 2023 02:27
@ErickRenteria
Copy link
Contributor

Validated

@ErickRenteria ErickRenteria merged commit eacf913 into master Apr 20, 2023
@tombrunet tombrunet deleted the dev-1389 branch August 15, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tombrunet tombrunet tombrunet approved these changes

Assignees
No one assigned
Labels
Ready for QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix bound calculation issue Rule firing sometimes results in triangle
3 participants
@shunguoy @ErickRenteria @tombrunet