Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Valerie_Label_HasContent): add more test cases for shadow DOM slot tests #1363

Merged
merged 7 commits into from
Mar 29, 2023
Merged

chore(Valerie_Label_HasContent): add more test cases for shadow DOM slot tests #1363

merged 7 commits into from
Mar 29, 2023

Conversation

shunguoy
Copy link
Contributor

This PR is related to the following issue(s):

#1226

Additional information can be found here:

Testing reference:

I have conducted the following for this PR:

  • [x ] I validated this code in Chrome and FF
  • [x ] I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • [x ] I understand that the title of this PR will be used for the next release notes.

@shunguoy shunguoy requested a review from tombrunet March 29, 2023 19:43
@shunguoy shunguoy marked this pull request as ready for review March 29, 2023 19:45
@tombrunet tombrunet merged commit c775bd2 into master Mar 29, 2023
@shunguoy shunguoy deleted the dev-1226 branch April 3, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tombrunet tombrunet Awaiting requested review from tombrunet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shunguoy @tombrunet