Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): Fix ruleID dependencies, and context dependency, and create a cache function computation #1357

Merged
merged 10 commits into from
Mar 28, 2023

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Mar 22, 2023

  • Rule bug: List rule IDs
    Rpt_Aria_ValidPropertyValue
    aria_attribute_conflict
    aria_attribute_redundant
    aria_role_redundant
    aria_semantics_role
    table_aria_descendants

This PR is related to the following issue(s):

#1330

Additional information can be found here:

Testing reference:

/test/v2/checker/accessibility/rules/aria_attribute_redundant_ruleunit/Fail.html

I have conducted the following for this PR:

  • [x ] I validated this code in Chrome and FF
  • [x ] I validated this fix in my local env
  • [x ] I provided details for testing
  • This PR has been reviewed and is ready for test
  • [x ] I understand that the title of this PR will be used for the next release notes.

@shunguoy shunguoy requested a review from tombrunet March 22, 2023 20:00
@shunguoy shunguoy marked this pull request as ready for review March 22, 2023 20:01
@ErickRenteria ErickRenteria merged commit 6d42559 into master Mar 28, 2023
@shunguoy shunguoy deleted the dev-1330 branch April 3, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants