issue-1354: [Feature]: request node_module is deprecated and missing maintain, @cypress/request forked it to maintain #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…maintain, @cypress/request forked it to maintain
tombrunet
previously approved these changes
Mar 22, 2023
|
@gjunming Can you fix the one in src/lib/log/ACMetricsLogger.js also? It wouldn't let me add that file into your forked change. I made some other tweaks since you were pulling from a private artifactory in package-lock, and the uuid package was no longer pulled in with require. |
|
@tombrunet , I fixed the missing replacement in ACMetricsLogger.js, |
tombrunet
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.