-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
newrule(iframe_interactive_tabbable) Iframe with interactive content should not be excluded from tab order using tabindex #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync dev-1156 with dev-1154
Closed
9 tasks
4 tasks
philljenkins
changed the title
newrule(iframe_interactive_tabbable) Iframe with interactive content should not be excluded from focus order using tabindex
newrule(iframe_interactive_tabbable) Iframe with interactive content should not be excluded from tab order using tabindex
Feb 20, 2023
5 tasks
shunguoy
requested review from
philljenkins and
tombrunet
and removed request for
philljenkins
February 21, 2023 15:30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly similar files as PR #1306. But 1306 has a couple later updates for example in element_scrollable_tabbable.html
tombrunet
approved these changes
Feb 22, 2023
Validated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
newrule(iframe_interactive_tabbable) Iframe with interactive content should not be excluded from focus order using tabindex
This PR is related to the following issue(s):
#1154 #1283
Testing reference:
https://wai-wcag-act-rules.netlify.app/standards-guidelines/act/rules/akn7bn/proposed/#visible
or
test/v2/checker/accessibility/rules/iframe_interactive_tabbable_ruleunit/*
I have conducted the following for this PR: