Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newrule(iframe_interactive_tabbable) Iframe with interactive content should not be excluded from tab order using tabindex #1287

Merged
merged 21 commits into from
Feb 22, 2023

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Feb 7, 2023

newrule(iframe_interactive_tabbable) Iframe with interactive content should not be excluded from focus order using tabindex

  • New Rule(s): List rule IDs. iframe_interactive_tabbable.ts
  • New or modified help files: List rule IDs. iframe_interactive_tabbable.html

This PR is related to the following issue(s):

#1154 #1283

Testing reference:

https://wai-wcag-act-rules.netlify.app/standards-guidelines/act/rules/akn7bn/proposed/#visible
or
test/v2/checker/accessibility/rules/iframe_interactive_tabbable_ruleunit/*

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@philljenkins philljenkins changed the title newrule(iframe_interactive_tabbable) Iframe with interactive content should not be excluded from focus order using tabindex newrule(iframe_interactive_tabbable) Iframe with interactive content should not be excluded from tab order using tabindex Feb 20, 2023
@shunguoy shunguoy requested review from philljenkins and tombrunet and removed request for philljenkins February 21, 2023 15:30
@shunguoy shunguoy marked this pull request as ready for review February 21, 2023 15:32
Copy link
Contributor

@philljenkins philljenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly similar files as PR #1306. But 1306 has a couple later updates for example in element_scrollable_tabbable.html

@ErickRenteria
Copy link
Contributor

Validated

@ErickRenteria ErickRenteria merged commit b8b1b46 into master Feb 22, 2023
@shunguoy shunguoy deleted the dev-1154 branch April 11, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants