Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add engine and tool support to allow rule id refactoring without updating baselines #1232

Merged
merged 8 commits into from
Jan 26, 2023
Merged

Add engine and tool support to allow rule id refactoring without updating baselines #1232

merged 8 commits into from
Jan 26, 2023

Conversation

tombrunet
Copy link
Member

@tombrunet tombrunet commented Jan 17, 2023 •
edited by ErickRenteria
Loading

  • Other (Provide information)

This PR adds support for refactoring rule ids and reason codes without failing baselines

This PR is related to the following issue(s):

Additional information can be found here:

Testing reference:

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@tombrunet tombrunet changed the title Add refactoring into the baseline Add engine and tool support to allow rule id refactoring without updating baselines Jan 17, 2023
@tombrunet tombrunet marked this pull request as ready for review January 17, 2023 21:05
@tombrunet tombrunet requested a review from aliunwala January 17, 2023 21:07
@ErickRenteria ErickRenteria merged commit 0a0b2b3 into master Jan 26, 2023
@tombrunet tombrunet deleted the refactor branch February 8, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliunwala aliunwala aliunwala approved these changes

Assignees
No one assigned
Labels
Ready for QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tombrunet @aliunwala @ErickRenteria