Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling when starting the SPL language server #89

Closed
queeniema opened this issue Jun 6, 2020 · 1 comment · Fixed by #92
Closed

Better error handling when starting the SPL language server #89

queeniema opened this issue Jun 6, 2020 · 1 comment · Fixed by #92
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@queeniema
Copy link
Contributor

  • If running in embedded mode and initialization takes longer than 1 minute, then show a notification to the user and ask them if they want to try switching to socket mode.
  • If running in socket mode, one issue users may run into is 'port already in use' errors if they have multiple VS Code windows open. The workaround for this is to use different port values for the Server: Port setting in the workspace settings for each window. To help users recover, we can detect if a port is in use and if so, show a notification to offer to change the port either temporarily (for the current session) or permanently (for the workspace).
@queeniema queeniema added the enhancement New feature or request label Jun 6, 2020
@queeniema queeniema self-assigned this Jun 6, 2020
@queeniema queeniema linked a pull request Jun 8, 2020 that will close this issue
@queeniema
Copy link
Contributor Author

Screen Shot 2020-06-08 at 4 13 49 PM

Screen Shot 2020-06-08 at 4 15 36 PM

@queeniema queeniema added this to the v1.0.2 milestone Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant