Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix bug in displacy serve method #46

Merged
merged 1 commit into from
Jan 4, 2023
Merged

🐛 Fix bug in displacy serve method #46

merged 1 commit into from
Jan 4, 2023

Conversation

marmg
Copy link
Collaborator

@marmg marmg commented Jan 4, 2023

Status Type ⚠️ Core Change Issue
Ready Bug No #45

Problem

Issue #45

 TypeError: serve() got an unexpected keyword argument 'jupyter'

Solution

Add jupyter option to kwargs in case it's render method.

Closes #45

Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
@marmg marmg force-pushed the fix/serve-jupyter branch from 6ca6cce to ff65793 Compare January 4, 2023 10:10
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 93.03% // Head: 93.04% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (ff65793) compared to base (36ffc6d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage   93.03%   93.04%           
=======================================
  Files          67       67           
  Lines        2830     2832    +2     
=======================================
+ Hits         2633     2635    +2     
  Misses        197      197           
Impacted Files Coverage Δ
zshot/utils/displacy/displacy.py 74.07% <100.00%> (+0.99%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marmg marmg merged commit 0127fd0 into main Jan 4, 2023
@marmg marmg deleted the fix/serve-jupyter branch January 4, 2023 11:00
marmg added a commit that referenced this pull request Mar 24, 2023
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
marmg added a commit that referenced this pull request Mar 24, 2023
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
marmg added a commit that referenced this pull request Mar 28, 2023
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
marmg added a commit that referenced this pull request Mar 30, 2023
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
marmg added a commit that referenced this pull request Mar 30, 2023
* 🐛 Fix bug in displacy serve method (#46)

* 🐛 Fix bug in zshot_evaluate import (#49)

* Refactor ensembler

* 🔒 Fix setuptools vulnerability

* 🐛 Fix deprecation in load_ontonotes. Fix bug in run_evaluation. Updated evaluation documentation. (#51)

* ✅ Added tests teardown and improve memory usage

* Update python-tests.yml

* ✅ Replace linkers in test_ensemble_linker with dummy linkers to speed up tests

* ✅ Improve coverage

* 🎨 Fix flake


---------

Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Co-authored-by: Gabriele Picco <piccogabriele@gmail.com>
Co-authored-by: t-l-hoang <t.l.hoang@ie.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: serve() got an unexpected keyword argument 'jupyter'
1 participant