Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add device option to Pipeline & Components #42

Merged
merged 2 commits into from
Dec 23, 2022

Conversation

GabrielePicco
Copy link
Contributor

@GabrielePicco GabrielePicco commented Dec 23, 2022

Add device configuration to the PipelineConf

Status Type ⚠️ Core Change Issue
Ready Feature No #7

Problem

Missing a central point to define the device option

Solution

Add device option to the pipeline configuration and all the components

Other changes (e.g. bug fixes, small refactors)

  • Simplify RelationExtraction model

Issues

Closes #7

Add device configuration to the PipelineConf
@GabrielePicco GabrielePicco changed the title ✨ Add device option ✨ Add device option to Pipeline & Components Dec 23, 2022
@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Base: 92.24% // Head: 92.93% // Increases project coverage by +0.68% 🎉

Coverage data is based on head (77fbbaa) compared to base (29f69d4).
Patch coverage: 97.75% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   92.24%   92.93%   +0.68%     
==========================================
  Files          67       67              
  Lines        2761     2773      +12     
==========================================
+ Hits         2547     2577      +30     
+ Misses        214      196      -18     
Impacted Files Coverage Δ
zshot/utils/models/smxm/data.py 98.64% <ø> (-0.02%) ⬇️
zshot/utils/models/smxm/model.py 100.00% <ø> (ø)
...shot/relation_extractor/relation_extractor_zsrc.py 96.49% <91.66%> (-3.51%) ⬇️
zshot/linker/linker.py 91.80% <100.00%> (+0.57%) ⬆️
zshot/linker/linker_smxm.py 96.55% <100.00%> (-0.23%) ⬇️
zshot/mentions_extractor/mentions_extractor.py 88.52% <100.00%> (+0.80%) ⬆️
...shot/mentions_extractor/mentions_extractor_smxm.py 100.00% <100.00%> (ø)
zshot/pipeline_config.py 100.00% <100.00%> (ø)
zshot/relation_extractor/relations_extractor.py 77.35% <100.00%> (+1.84%) ⬆️
...hot/relation_extractor/zsrc/zero_shot_rel_class.py 100.00% <100.00%> (+19.60%) ⬆️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GabrielePicco GabrielePicco merged commit e680379 into main Dec 23, 2022
@GabrielePicco GabrielePicco deleted the feature/add-device-option branch December 23, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add device option to the Pipeline configuration
1 participant