Skip to content

Commit

Permalink
🐛 Fixed TypeError type is not subscriptable in datasets (#28)
Browse files Browse the repository at this point in the history
Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>

Signed-off-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
Co-authored-by: Marcos Martinez <Marcos.Martinez.Galindo@ibm.com>
  • Loading branch information
marmg and marmg authored Nov 7, 2022
1 parent 79c1d29 commit d80d1f6
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
5 changes: 3 additions & 2 deletions zshot/evaluation/dataset/med_mentions/med_mentions.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import json
from typing import Dict, Union

from datasets import load_dataset, DatasetDict
from datasets import load_dataset, Split
from huggingface_hub import hf_hub_download

from zshot.evaluation.dataset.dataset import DatasetWithEntities
Expand All @@ -10,7 +11,7 @@
ENTITIES_FN = "entities.json"


def load_medmentions() -> DatasetDict[DatasetWithEntities]:
def load_medmentions() -> Dict[Union[str, Split], DatasetWithEntities]:
dataset = load_dataset(REPO_ID)
entities_file = hf_hub_download(repo_id=REPO_ID, repo_type='dataset',
filename=ENTITIES_FN)
Expand Down
6 changes: 4 additions & 2 deletions zshot/evaluation/dataset/ontonotes/onto_notes.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
from datasets import ClassLabel, load_dataset, DatasetDict
from typing import Dict, Union

from datasets import ClassLabel, load_dataset, DatasetDict, Split

from zshot.evaluation.dataset.dataset import DatasetWithEntities
from zshot.evaluation.dataset.ontonotes.entities import ONTONOTES_ENTITIES
Expand Down Expand Up @@ -52,7 +54,7 @@ def remove_out_of_split(sentence, split):
return sentence


def load_ontonotes() -> DatasetDict[DatasetWithEntities]:
def load_ontonotes() -> Dict[Union[str, Split], DatasetWithEntities]:
dataset_zs = load_dataset("conll2012_ontonotesv5", "english_v12")
ontonotes_zs = DatasetDict()

Expand Down

0 comments on commit d80d1f6

Please sign in to comment.