verify server certificate #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6f3d421 to
282b334
Compare
e937afe to
c1ba107
Compare
Signed-off-by: Neil Johnson <najohnsn@us.ibm.com>
c1ba107 to
fab5282
Compare
fcdce22 to
fb4c00d
Compare
Signed-off-by: Neil Johnson <najohnsn@us.ibm.com>
6aacc0f to
39aabdf
Compare
|
Potentially dumb comment as I haven't looked into this in a focused manner - an option to point to a cert bundle would be handy. This is how (ana/mini)conda, pypi, etc. do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides an enhancement that allows tnz to use the system default certificate store with a new environment variables:
Set
SESSION_SSL_VERIFY=certto require that the server provide a trusted certificate.Set
SESSION_SSL_VERIFY=hostnameto require that the certificate hostname match the requested hostname.Also defined new environment variable
SESSION_SECLEVELto replaceZTI_SECLEVEL. The new name is more consistent with other variable names and it allows the user the flexibility to set arbitrary security levels.