Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprectated transports do not work #39

Closed
kadler opened this issue May 28, 2019 · 2 comments
Closed

Deprectated transports do not work #39

kadler opened this issue May 28, 2019 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@kadler
Copy link
Member

kadler commented May 28, 2019

iRestCall, iDB2Call, and iLibCall do not work, bu t always return 'error': '*NODATA'.

The problem is caused by refactoring of the code as sub-classes of HttpTransport, DatabaseTransport, and DirectTransport and not returning a value from the sub-classed call methods, causing None to be returned instead.

@kadler kadler self-assigned this May 28, 2019
@kadler kadler added the bug Something isn't working label May 28, 2019
@jkyeung
Copy link
Contributor

jkyeung commented May 28, 2019

Functions in quite a few languages return the last-evaluated expression in the absence of an explicit return. My guess is you slipped into Ruby mode. ;)

@kadler kadler closed this as completed in 70ce259 May 28, 2019
@kadler
Copy link
Member Author

kadler commented May 28, 2019

I actually do not like that behavior, so never did that in Ruby (even if it was idiomatic 🤷‍♂️).

I think I was just re-structuring them all at once and making sure to get the super() call formatted correctly and working across Python 2/3 that I missed the return.

jkyeung pushed a commit to jkyeung/python-itoolkit that referenced this issue May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants