Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Global Catalog): fix price field capitalization #265

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

benbuchanan
Copy link

PR summary

Regen after api definition fixes like Price to price, include url field for object update, and support deployment_region query param

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Fixes object update and price field syntax

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Integration tests

[INFO] Tests run: 27, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.30 s -- in com.ibm.cloud.platform_services.global_catalog.v1.GlobalCatalogIT

Example tests

No errors above
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  18.822 s
[INFO] Finished at: 2025-03-13T10:01:13-04:00
[INFO] ------------------------------------------------------------------------

Signed-off-by: Ben Buchanan <buchanan@ibm.com>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@benbuchanan benbuchanan requested a review from padamstx March 13, 2025 15:07
@padamstx padamstx self-assigned this Mar 13, 2025
@padamstx padamstx changed the title fix(GlobalCatalog): regen after api def fixes fix(Global Catalog): fix price field capitalization Mar 13, 2025
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just had a question about the removal of the example code fragment for the getPricing() operation.

@@ -324,26 +325,6 @@ public static void main(String[] args) throws Exception {
System.out.println("updateVisibility returned the following error: " + e.getMessage());
}

try {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the example for the getPricing() operation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants