Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: prevent semrel from committing package-lock.json #102

Merged
merged 1 commit into from
May 17, 2021
Merged

build: prevent semrel from committing package-lock.json #102

merged 1 commit into from
May 17, 2021
+5 −826

Conversation

padamstx
Copy link
Member

PR summary

This PR removes package-lock.json and prevents semantic-release from committing it again in a future release build.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Sorry, something went wrong.

@padamstx padamstx self-assigned this May 14, 2021
@padamstx padamstx requested a review from pyrooka May 14, 2021 23:16
pyrooka
pyrooka approved these changes May 17, 2021
View reviewed changes
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@padamstx padamstx merged commit 3b4ab04 into main May 17, 2021
@padamstx padamstx deleted the remove-pkglock branch May 17, 2021 14:57
@ibm-devx-sdk
Copy link
Contributor

🎉 This PR is included in version 0.18.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

JonahFarc pushed a commit to JonahFarc/platform-services-java-sdk that referenced this pull request Sep 15, 2021
@pyrooka
fix(IAM Identity): update service after recent API changes (IBM#102)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
713775a
JonahFarc pushed a commit to JonahFarc/platform-services-java-sdk that referenced this pull request Sep 15, 2021
@semantic-release-bot
chore(release): 0.18.8 [skip ci]
e1fc7a7 
## [0.18.8](IBM/platform-services-node-sdk@v0.18.7...v0.18.8) (2021-04-26)

### Bug Fixes

* **IAM Identity:** update service after recent API changes ([IBM#102](IBM/platform-services-node-sdk#102)) ([713775a](IBM/platform-services-node-sdk@713775a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrooka pyrooka

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@padamstx @ibm-devx-sdk @pyrooka