Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(IAM Access Groups): Add CRN filter #373

Merged
merged 1 commit into from
Feb 11, 2025
Merged

feat(IAM Access Groups): Add CRN filter #373

merged 1 commit into from
Feb 11, 2025

Conversation

hariarla
Copy link
Contributor

@hariarla hariarla commented Feb 11, 2025 •
edited
Loading

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Tests:
Screenshot 2025-02-11 at 4 52 49 PM
Example Tests:
Screenshot 2025-02-11 at 9 09 24 PM
Integration Tests:
Screenshot 2025-02-11 at 10 38 46 PM

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Hari Krishna Arla seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

feat(IAM Access Groups): Add CRN filter
661b538 
Signed-off-by: Hari Krishna Arla <harikarla@Haris-MacBook-Pro.local>
@padamstx padamstx self-assigned this Feb 11, 2025
padamstx
padamstx approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 5f2bc85 into main Feb 11, 2025
11 of 12 checks passed
@padamstx padamstx deleted the include_crn_filter branch February 11, 2025 17:47
ibm-devx-sdk pushed a commit that referenced this pull request Feb 11, 2025
@semantic-release-bot
chore(release): 0.75.0 release notes [skip ci]
546a851 
# [0.75.0](v0.74.1...v0.75.0) (2025-02-11)

### Features

* **IAM Access Groups:** Add CRN filter ([#373](#373)) ([5f2bc85](5f2bc85))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.75.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hariarla @CLAassistant @ibm-devx-sdk @padamstx