Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(IAM Identity): add Identity Preference API #370

Merged
merged 1 commit into from
Feb 4, 2025
Merged

feat(IAM Identity): add Identity Preference API #370

merged 1 commit into from
Feb 4, 2025

Conversation

pooraniss-ibm
Copy link
Member

@pooraniss-ibm pooraniss-ibm commented Jan 28, 2025 •
edited
Loading

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pooraniss-ibm pooraniss-ibm force-pushed the iam-identity-preferences branch 2 times, most recently from 599734a to a0a1b37 Compare January 28, 2025 16:18
@padamstx padamstx self-assigned this Jan 28, 2025
@padamstx
Copy link
Member

@pooraniss-ibm the failure in the DCO check is due to you not using the -s option (sign off) with git commit. Could you please amend your commit like this:
git commit -s --amend, then force-push (git push -f) to update your commit?

@padamstx padamstx self-requested a review January 28, 2025 22:00
padamstx
padamstx requested changes Jan 28, 2025
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good. Just need to address my comment re: the endpoint URL in the generator code.

Edit: when you address the endpoint URL issue, you can use an amended commit instead of a whole new commit. Also, you can add the -s option: git commit -s --amend

@pooraniss-ibm
feat(IAM Identity): adding Identity Preference API
9d79647 
Signed-off-by: poorani <poorani.senthilkumar.sankari@ibm.com>
@pooraniss-ibm pooraniss-ibm force-pushed the iam-identity-preferences branch from a0a1b37 to 9d79647 Compare January 30, 2025 10:16
padamstx
padamstx approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx changed the title feat(IAM Identity): adding Identity Preference API feat(IAM Identity): add Identity Preference API Jan 30, 2025
@padamstx padamstx merged commit 34d910b into main Feb 4, 2025
12 checks passed
@padamstx padamstx deleted the iam-identity-preferences branch February 4, 2025 15:30
ibm-devx-sdk pushed a commit that referenced this pull request Feb 4, 2025
@semantic-release-bot
chore(release): 0.74.0 release notes [skip ci]
ba77ab4 
# [0.74.0](v0.73.0...v0.74.0) (2025-02-04)

### Features

* **IAM Identity:** add Identity Preference API ([#370](#370)) ([34d910b](34d910b))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.74.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pooraniss-ibm @padamstx @ibm-devx-sdk