Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating to MobX 6 #89

Merged
merged 4 commits into from
Jan 4, 2023
Merged

Migrating to MobX 6 #89

merged 4 commits into from
Jan 4, 2023

Conversation

zibra
Copy link
Contributor

@zibra zibra commented Jun 18, 2021

No description provided.

@zibra zibra closed this Jun 21, 2021
@zibra zibra reopened this Jun 21, 2021
@gcattan
Copy link
Collaborator

gcattan commented Jan 3, 2023

@zibra it looks good to me. Did you run npm test on it or use it on your project recently?

@gcattan gcattan mentioned this pull request Jan 4, 2023
Merged
gcattan
gcattan approved these changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@gcattan gcattan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated your package.json and added a CI file for npm test.
Sounds good to me.

@gcattan gcattan merged commit e1bd68e into IBM:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcattan gcattan gcattan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zibra @gcattan