feat(ContainerAuthenticator): enhance ContainerAuthenticator to support Code Engine workload #232
+15
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@SaschaSchwarze0 the build failures are due to checkstyle errors. To see the same errors in your local sandbox, you can run |
padamstx
requested changes
Mar 6, 2025
…rt Code Engine workload Signed-off-by: Sascha Schwarze <schwarzs@de.ibm.com>
a7ea093 to
7a5de1c
Compare
Thanks. I did not check the status myself and locally only ran |
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Mar 7, 2025
# [9.23.0](9.22.2...9.23.0) (2025-03-07) ### Features * **ContainerAuthenticator:** add support for code engine workload ([#232](#232)) ([166d8f6](166d8f6))
|
🎉 This PR is included in version 9.23.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request extends the existing ContainerAuthenticator to be aware of the hard-coded compute resource token path used by Code Engine. This allows a seamless usage of that authenticator and a move of workload between IKS/ROKS/Code Engine without changing a single line of code.
Documentation is adjusted to mention Code Engine in the context of the ContainerAuthenticator.