Added helm charts. #13
Conversation
| @@ -0,0 +1,10 @@ | |||
| replicaCount: 1 | |||
| image: | |||
| repository: ffdl/ibmcloud-object-storage-plugin | |||
There was a problem hiding this comment.
I think the registry belongs to ffdl project. Is ffdl updating the image regularly?
I think better need to document the steps to create image and push to registry and then how to use the chart to deploy plug-in
There was a problem hiding this comment.
FfDL image is only updated sporadically - one reason for migrating the helm charts. It probably makes sense to maintain images as part of this project [which is, of course, not up to me to decide].
| apiVersion: v1 | ||
| description: A Helm chart for ibmcloud-object-storage plugin | ||
| name: ibmcloud-object-storage-plugin | ||
| version: 0.1 |
There was a problem hiding this comment.
I think same charts are available under https://github.com/IBM/FfDL/blob/master/storage-plugin/Chart.yaml
I think better to keep chart at one place.
There was a problem hiding this comment.
Completely agree. Since there are almost certainly more people who want to deploy the driver with Helm than just FfDL, it should make sense to maintain the helm charts in the driver repository rather than FfDL.
| hostPath: | ||
| path: /run/systemd | ||
| imagePullSecrets: | ||
| - name: regcred |
There was a problem hiding this comment.
Is regcred for FFDL registry?
I think the steps to create image, push image and create image pull secrets from privet registry should be documented.
There was a problem hiding this comment.
Documentation sounds good. regcred is a Kubernetes pull secret for the registry that you create via
kubectl create secret docker-registry regcred --docker-server=${DOCKER_REPO} --docker-username=${DOCKER_REPO_USER} --docker-password=${DOCKER_REPO_PASS} --docker-email=unknown@docker.io
However, these helm charts only seem to work for IBM Cloud as does the standard installation procedure of the driver. With DIND Kubernetes I run into issues - will open a separate bug issue with a workaround.