Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review changes from scripts-dev to scripts-adopter #2291

Merged
merged 8 commits into from
Nov 15, 2024
Merged

Review changes from scripts-dev to scripts-adopter #2291

merged 8 commits into from
Nov 15, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Nov 6, 2024

common service installer automation on 2024-11-06-22-12-17

@bitscuit
updated actions/upload-artifact to v4 (#2290)
f1f5380 
Signed-off-by: Henry Li <henry.h.li@ibm.com>
@github-actions GitHub Actions
Copy link
Author

github-actions bot commented Nov 6, 2024

please add label ok-to-sync and remove label do-not-merge/hold to merge the PR

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: github-actions[bot]
Once this PR has been reviewed and has the lgtm label, please assign bitscuit for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot
Copy link
Collaborator

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a IBM member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ujjwalchk-it
Adding IM turbo manifests (#2289)
fc39a63 
* adding im turbo manifests

Signed-off-by: Ujjwal Chakraborty <53339037+ujjwalchk-it@users.noreply.github.com>

* adding im turbo manifests

Signed-off-by: Ujjwal Chakraborty <53339037+ujjwalchk-it@users.noreply.github.com>

* adding im turbo manifests

Signed-off-by: Ujjwal Chakraborty <53339037+ujjwalchk-it@users.noreply.github.com>

---------

Signed-off-by: Ujjwal Chakraborty <53339037+ujjwalchk-it@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Author

github-actions bot commented Nov 7, 2024

please add label ok-to-sync and remove label do-not-merge/hold to merge the PR

@ibm-ci-bot ibm-ci-bot added size/M and removed size/XS labels Nov 7, 2024
@qpdpQ
exclude internal generated operandrequest from Backup/Restore (#2273)
201efdb 
* stop BR internal generated operandrequest

Signed-off-by: Allen Li <liyuchen223@gmail.com>

* removed duplicate check

Signed-off-by: Allen Li <liyuchen223@gmail.com>

---------

Signed-off-by: Allen Li <liyuchen223@gmail.com>
@github-actions GitHub Actions
Copy link
Author

github-actions bot commented Nov 7, 2024

please add label ok-to-sync and remove label do-not-merge/hold to merge the PR

@bluzarraga
add common-web-ui-config cm to labeling script (#2294)
ea2d0d4 
Signed-off-by: Ben Luzarraga <luzarragaben@gmail.com>
@github-actions GitHub Actions
Copy link
Author

github-actions bot commented Nov 7, 2024

please add label ok-to-sync and remove label do-not-merge/hold to merge the PR

@github-actions GitHub Actions
Copy link
Author

github-actions bot commented Nov 7, 2024

please add label ok-to-sync and remove label do-not-merge/hold to merge the PR

@ibm-ci-bot ibm-ci-bot added size/L and removed size/M labels Nov 7, 2024
@bitscuit
turbonomic ORM for ibm-cert-manager (#2292)
48b91ce 
* test-shell-linter

Signed-off-by: Henry Li <henry.h.li@ibm.com>

* added turbonomic ORM for cert-manager-operands

Signed-off-by: Henry Li <henry.h.li@ibm.com>

* removed throwaway file

Signed-off-by: Henry Li <henry.h.li@ibm.com>

---------

Signed-off-by: Henry Li <henry.h.li@ibm.com>
@github-actions GitHub Actions
Copy link
Author

github-actions bot commented Nov 7, 2024

please add label ok-to-sync and remove label do-not-merge/hold to merge the PR

@github-actions GitHub Actions
Copy link
Author

please add label ok-to-sync and remove label do-not-merge/hold to merge the PR

@Daniel-Fan
add related permission for MongoDB cleanup in post DB migration (#2305)
465c427 
Signed-off-by: Daniel Fan <fanyuchensx@gmail.com>
@github-actions GitHub Actions
Copy link
Author

please add label ok-to-sync and remove label do-not-merge/hold to merge the PR

@github-actions github-actions bot merged commit 465c427 into scripts-adopter Nov 15, 2024
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daniel-Fan Daniel-Fan Awaiting requested review from Daniel-Fan

@qpdpQ qpdpQ Awaiting requested review from qpdpQ

Assignees
No one assigned
Labels
needs-ok-to-test ok-to-sync size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ibm-ci-bot @Daniel-Fan @bitscuit @ujjwalchk-it @qpdpQ @bluzarraga @sgrube