fix: remove _running/stop machinery #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `while (!stop.get())` logic was faulty since the loop will always be exited with 0 changes, some changes, or null. - `_running` and `stop` variables not needed: if connector is removed or shutdown using the connect REST api, then `stop` will be called on the same thread as `poll`. Therefore these methods can be considered fully synchronous and there is no such thing as an "in flight" or "pending" request to cloudant. This was observed in both standalone and distributed configuration. - Narrow scope of `cloudantChangesResult` by moving to local variable.
ricellis
requested changes
Sep 20, 2022
|
oh sorry nvm, that's a different stop(!) |
ricellis
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while (!stop.get())logic was faulty since the loop will always be exited with 0 changes, some changes, or null._runningandstopvariables not needed: if connector is removed or shutdown using the connect REST api, thenstopwill be called on the same thread aspoll. Therefore these methods can be considered fully synchronous and there is no such thing as an "in flight" or "pending" request to cloudant. This was observed in both standalone and distributed configuration.cloudantChangesResultby moving to local variable.Fixes #94