feat: Emit tombstones for deleted documents #88
Conversation
fca5481 to
ce13258
Compare
| Schema.STRING_SCHEMA, // key schema | ||
| id, // key | ||
| docSchema, // value schema | ||
| docValue); // value | ||
| records.add(sourceRecord); | ||
| if (doc.isDeleted() != null && doc.isDeleted()) { |
There was a problem hiding this comment.
Not specific to this line, but I think it would be worth adding a test for the tombstone to protect against regressing it.
f090c7d to
c42052e
Compare
TODO - tests need cleaning up Fixes #73
c42052e to
91b0902
Compare
| expect(mockResult.getLastSeq()).andReturn("100"); | ||
| expect(changesResultItem.getChanges()).andReturn(Collections.singletonList(change)); | ||
| expect(changesResultItem.getDoc()).andReturn(document); | ||
| expect(changesResultItem.getId()).andReturn(id); |
There was a problem hiding this comment.
I was surprised to not see ChangesResultItem's isDeleted mocked out here. Of course checking the implementation again I see we are checking the field on the doc instead.
I think the implementation is fine as we have the doc anyway.
There was a problem hiding this comment.
Yes - the test fails if I mock isDeleted but don't set deleted on the document itself.
| Assert.assertEquals(2, records.size()); | ||
| Assert.assertNotNull(records.get(0).value()); | ||
| Assert.assertNull(records.get(1).value()); | ||
| // TODO unpack record json and assert on it |
There was a problem hiding this comment.
I don't think this TODO is necessary, asserting the record value is null is sufficient to know it is a tombstone.
Arguably we could have a second test that validates that we don't get a second record when the change wasn't a deleted doc, but I expect assertions elsewhere are covering that.
| @@ -0,0 +1,100 @@ | |||
| package com.ibm.cloud.cloudant.kafka.connect; | |||
| @@ -0,0 +1,10 @@ | |||
| package com.ibm.cloud.cloudant.kafka.connect; | |||
Documentation
Update README and CHANGES
Testing
Tested locally by deleting document from Cloudant and observing event with
./bin/kafka-console-consumer.sh --bootstrap-server localhost:9092 --topic kafka_test --from-beginning --property print.key=true