Stop removing _rev from sink documents
#77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricellis
approved these changes
Jun 6, 2022
README.md
Outdated
| transforms.ReplaceField.type=org.apache.kafka.connect.transforms.ReplaceField$Value | ||
| transforms.ReplaceField.blacklist=_rev | ||
| ``` | ||
| For more details, see [`ReplaceField`](https://docs.confluent.io/platform/current/connect/transforms/replacefield.html#replacefield) documentation. |
There was a problem hiding this comment.
We should probably point to the Apache Kafka documentation rather than the Confluent Platform.
Sadly it doesn't have a direct link to ReplaceField but it is listed amongst the transforms in https://kafka.apache.org/31/documentation.html#connect_transforms
tomblench
reviewed
Jun 6, 2022
README.md
Outdated
| ``` | ||
| transforms=ReplaceField | ||
| transforms.ReplaceField.type=org.apache.kafka.connect.transforms.ReplaceField$Value | ||
| transforms.ReplaceField.blacklist=_rev |
There was a problem hiding this comment.
As discussed, should probably use exclude instead of blacklist
tomblench
reviewed
Jun 6, 2022
tomblench
reviewed
Jun 7, 2022
src/test/java/com/ibm/cloudant/kafka/connect/CloudantSourceAndSinkTest.java
Outdated
Show resolved
Hide resolved
tomblench
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGES.md|CHANGELOG.md) or test/build only changesDescription
fixes #72
Approach
Schema & API Changes
Security and Privacy
Testing
Monitoring and Logging