Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

53: Fix publishing #59

Merged
merged 1 commit into from
Feb 22, 2022
Merged

53: Fix publishing #59

merged 1 commit into from
Feb 22, 2022

Conversation

tomblench
Copy link
Contributor

Checklist

  • Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1
  • Added tests for code changes or test/build only changes
  • Updated the change log file (CHANGES.md|CHANGELOG.md) or test/build only changes
  • Completed the PR template below:

Description

Fix publishing to use the new gradle model. NB this is now achieved by the publish task.

Approach

Remove and rewrite uploadArchives task per advice here

Schema & API Changes

No change

Security and Privacy

No change

Testing

Tested locally up to point of actually publishing assets, ie

./gradlew -i -Dsigning.secretKeyRingFile=/home/tomblench/.gnupg/secring.gpg -Dsigning.password=test -Dsigning.keyId=xxx -DossrhUsername=fake -DossrhPassword=fake clean publish

Observed that files are output to correct locations, and publishMavenJavaPublicationToMavenRepository step fails as expected Received status code 401 from server: Unauthorized.

Monitoring and Logging

No change

Copy link
Contributor

@emlaver emlaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@tomblench tomblench merged commit fe8f996 into master Feb 22, 2022
@tomblench tomblench deleted the 53-fix-publishing branch February 22, 2022 17:05
@ricellis ricellis mentioned this pull request Mar 1, 2022
@ricellis ricellis added this to the 0.100.next milestone May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants