50 migrate to new sdk #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricellis
reviewed
Jan 28, 2022
src/main/java/com/ibm/cloudant/kafka/common/utils/JavaCloudantUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ibm/cloudant/kafka/common/utils/JavaCloudantUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ibm/cloudant/kafka/common/utils/JavaCloudantUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ibm/cloudant/kafka/common/utils/JavaCloudantUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ibm/cloudant/kafka/common/utils/JavaCloudantUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ibm/cloudant/kafka/common/utils/JavaCloudantUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ibm/cloudant/kafka/connect/CloudantSourceTask.java
Outdated
Show resolved
Hide resolved
| .build(); | ||
| Response<Ok> result = service.deleteDatabase(deleteDbOptions).execute(); | ||
| if (!result.getResult().isOk()) { | ||
| LOG.error(String.format("Error during deletion of database %s. Error code: %d Error response: %s", |
There was a problem hiding this comment.
What is the motivation for logging in the test vs just failing?
There was a problem hiding this comment.
I removed this log and added an assertion in df22ab8
45ef249 to
df22ab8
Compare
ricellis
reviewed
Feb 3, 2022
src/main/java/com/ibm/cloudant/kafka/common/utils/JavaCloudantUtil.java
Outdated
Show resolved
Hide resolved
ricellis
approved these changes
Feb 4, 2022
Co-authored-by: Rich Ellis <ricellis@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGES.md|CHANGELOG.md) or test/build only changesDescription
fixes #50
The underlying Cloudant client library is now EOL. This PR refactored the codebase and tests to use the new
cloudant-java-sdklibrary.Approach
Schema & API Changes
"No change"
Security and Privacy
Testing
Updated existing tests to use new library.
No new tests.
Monitoring and Logging