Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: simplify signing #174

Merged
merged 1 commit into from
May 12, 2023
Merged

build: simplify signing #174

merged 1 commit into from
May 12, 2023

Conversation

ricellis
Copy link
Member

Checklist

  • Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1
  • Added tests for code changes or test/build only changes
  • Updated the change log file (CHANGES.md|CHANGELOG.md) or test/build only changes
  • Completed the PR template below:

Description

Simplify jar signing

Approach

Use an alternate executor without need for a separate signing container and writing of the config file.

Schema & API Changes

  • "No change"

Security and Privacy

  • "No change"

Testing

  • N/A build or packaging only changes

Monitoring and Logging

  • "No change"

@ricellis ricellis self-assigned this May 12, 2023
eiri
eiri approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@eiri eiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 given it passes on updated full agent

@ricellis ricellis merged commit cca045a into main May 12, 2023
@ricellis ricellis deleted the s707-signing branch May 12, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eiri eiri eiri approved these changes

Assignees

@ricellis ricellis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricellis @eiri