Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

138 dependencies #163

Merged
merged 1 commit into from
May 2, 2023
Merged

138 dependencies #163

merged 1 commit into from
May 2, 2023

Conversation

ricellis
Copy link
Member

@ricellis ricellis commented May 2, 2023

Checklist

  • Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1
  • Added tests for code changes or test/build only changes
  • Updated the change log file (CHANGES.md|CHANGELOG.md) or test/build only changes
  • Completed the PR template below:

Description

Use built-in configurations for dependency management.

Fixes #138

Approach

  • Remove custom bundleImplementation configuration and replace it with runtimeClasspath.
  • Use compileOnly for Apache Kafka and other dependencies that are provided at runtime.
  • Modify the testImplementation configuration to include the compileOnly non-test dependencies so that tests can run even when not deployed in Kafka.

Schema & API Changes

  • "No change"

Security and Privacy

  • "No change"

Testing

  • N/A build or packaging only changes; checked content of output jar is the same as previously.

Monitoring and Logging

  • "No change"

@ricellis ricellis self-assigned this May 2, 2023
@ricellis ricellis force-pushed the 138-dependencies branch from ee1a4cf to de9260c Compare May 2, 2023 13:28
@ricellis ricellis merged commit 8b01187 into main May 2, 2023
@ricellis ricellis deleted the 138-dependencies branch May 2, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit build.gradle dependency declarations
2 participants