Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: package as zip instead of jar #142

Merged
merged 1 commit into from
Nov 2, 2022
Merged

build: package as zip instead of jar #142

merged 1 commit into from
Nov 2, 2022

Conversation

ricellis
Copy link
Member

@ricellis ricellis commented Nov 2, 2022

Checklist

  • Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1
  • Added tests for code changes or test/build only changes - build changes
  • Updated the change log file (CHANGES.md|CHANGELOG.md) or test/build only changes - build changes, will document in release notes.
  • Completed the PR template below:

Description

Package as a zip instead of an "uber jar".

Approach

The "uber jar" failed to include all content from bundled dependencies because of path clashes. It is better to packge a directory so the dependencies can remain in their own jars.

This is achieved by using the gradle distribution plugin and creating a zip file.

Schema & API Changes

  • Change in installation method.

Security and Privacy

  • "No change"

Testing

  • N/A build or packaging only changes, but did verify new output content, signature and function.

Monitoring and Logging

  • "No change"

@ricellis ricellis added this to the 0.200.0 milestone Nov 2, 2022
@ricellis ricellis self-assigned this Nov 2, 2022
@ricellis ricellis requested a review from tomblench November 2, 2022 11:21
Copy link
Contributor

@tomblench tomblench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should include docs/ dir too

@ricellis
Copy link
Member Author

ricellis commented Nov 2, 2022

Added docs in 97606e8

@ricellis ricellis merged commit d3aa3d6 into main Nov 2, 2022
@ricellis ricellis deleted the dist-packaging branch November 2, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants