Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: assign since correctly in changes follower #630

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

ricellis
Copy link
Member

@ricellis ricellis commented Nov 6, 2024

PR summary

Assign since correctly when initializing ChangesResultSpliterator

Fixes: #629

Note: An existing issue is required before opening a PR.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the
    Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

this.since is used when copying the options for the request, but this.since is only set for the default null cases.

What is the new behavior?

Set this.since to this.options.since() and only then apply the defaults if necessary.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ricellis ricellis self-assigned this Nov 6, 2024
@ricellis ricellis merged commit f9e5150 into main Nov 7, 2024
8 checks passed
@ricellis ricellis deleted the fix-follower-since branch November 7, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes follower since value ignored
3 participants