fix: HOT FIX to include properties from issue 5579

[tyao117]

• include the following properties to scc_instance_settings:
  • source_description
  • source_name

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000
#5817
#5579

Output from acceptance testing:

$ make testacc TEST=./ibm/service/scc  TESTARGS="-run TestAccIbmSccInstance*"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/scc -v -run TestAccIbmSccInstance* -timeout 700m
...
=== RUN   TestAccIbmSccInstanceSettingsDataSourceBasic
--- PASS: TestAccIbmSccInstanceSettingsDataSourceBasic (14.45s)
=== RUN   TestAccIbmSccInstanceSettingsBasic
--- PASS: TestAccIbmSccInstanceSettingsBasic (15.98s)
=== RUN   TestAccIbmSccInstanceSettingsAllArgs
--- PASS: TestAccIbmSccInstanceSettingsAllArgs (32.19s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/scc     63.066s

[ocofaigh]

Although its marked as optional, this should probably say its required if a value is passed for instance_crn. Otherwise you get this:

│ Error: event_notifications.source_name needs to be defined along with event_notifications.instance_crn
│ 
│   with module.create_scc_instance.ibm_scc_instance_settings.scc_instance_settings[0],
│   on ../../main.tf line 89, in resource "ibm_scc_instance_settings" "scc_instance_settings":
│   89: resource "ibm_scc_instance_settings" "scc_instance_settings" {