Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibm_container_vpc_worker_pool - remove Computed for secondary_storage property #5720

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

z0za
Copy link
Contributor

@z0za z0za commented Oct 11, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

% make testacc TEST=./ibm/service/kubernetes TESTARGS='-run=TestAccIBMContainerVpcClusterWorkerPool'
...
=== RUN   TestAccIBMContainerVpcClusterWorkerPoolDataSourceBasic
--- PASS: TestAccIBMContainerVpcClusterWorkerPoolDataSourceBasic (1081.74s)
=== RUN   TestAccIBMContainerVpcClusterWorkerPoolDataSourceDedicatedHost
[WARN] Skipping TestAccIBMContainerVpcClusterWorkerPoolResourceDedicatedHost - IBM_CONTAINER_DEDICATEDHOST_POOL_ID is unset
--- PASS: TestAccIBMContainerVpcClusterWorkerPoolDataSourceDedicatedHost (0.00s)
=== RUN   TestAccIBMContainerVpcClusterWorkerPoolDataSourceSecondaryStorage
--- PASS: TestAccIBMContainerVpcClusterWorkerPoolDataSourceSecondaryStorage (1293.06s)
=== RUN   TestAccIBMContainerVpcClusterWorkerPoolDataSourceKMS
--- PASS: TestAccIBMContainerVpcClusterWorkerPoolDataSourceKMS (1363.61s)
=== RUN   TestAccIBMContainerVpcClusterWorkerPoolDataSourceKmsAccount
--- PASS: TestAccIBMContainerVpcClusterWorkerPoolDataSourceKmsAccount (1422.21s)
=== RUN   TestAccIBMContainerVpcClusterWorkerPoolResourceBasic
--- PASS: TestAccIBMContainerVpcClusterWorkerPoolResourceBasic (1487.21s)
=== RUN   TestAccIBMContainerVpcClusterWorkerPoolResourceSecurityGroups
--- PASS: TestAccIBMContainerVpcClusterWorkerPoolResourceSecurityGroups (1341.94s)
=== RUN   TestAccIBMContainerVpcClusterWorkerPoolResourceDedicatedHost
[WARN] Skipping TestAccIBMContainerVpcClusterWorkerPoolResourceDedicatedHost - IBM_CONTAINER_DEDICATEDHOST_POOL_ID is unset
--- PASS: TestAccIBMContainerVpcClusterWorkerPoolResourceDedicatedHost (0.00s)
=== RUN   TestAccIBMContainerVpcClusterWorkerPoolResourceSecondaryStorage
--- PASS: TestAccIBMContainerVpcClusterWorkerPoolResourceSecondaryStorage (1605.29s)
=== RUN   TestAccIBMContainerVpcClusterWorkerPoolResourceKMS
--- PASS: TestAccIBMContainerVpcClusterWorkerPoolResourceKMS (1437.07s)
=== RUN   TestAccIBMContainerVpcClusterWorkerPoolResourceKmsAccount
--- PASS: TestAccIBMContainerVpcClusterWorkerPoolResourceKmsAccount (1569.82s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes      12607.506s
...

@z0za z0za force-pushed the secondary_storage_remove branch from 0d5870e to bc4af60 Compare October 14, 2024 14:05
@z0za z0za force-pushed the secondary_storage_remove branch from 0444114 to b6c46a8 Compare October 18, 2024 11:58
@z0za z0za marked this pull request as ready for review October 21, 2024 10:48
@hkantare hkantare merged commit 15e4757 into IBM-Cloud:master Oct 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants