Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update error diagnostic reporting in existing Event Streams code #5685

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

kccox
Copy link
Contributor

@kccox kccox commented Sep 25, 2024

What has been done

Update the contextualized error messages in existing Event Streams code to use the flex.TerraformErrorf package, as in https://github.ibm.com/CloudEngineering/client-error-toolchain/wiki/Terraform-Support-Instructions.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:


% make testacc TEST=./ibm/service/eventstreams TESTARGS='-run=TestAccIBMEventStreamsTopicDataSourceBasic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/eventstreams -v -run=TestAccIBMEventStreamsTopicDataSourceBasic -timeout 700m
=== RUN   TestAccIBMEventStreamsTopicDataSourceBasic
--- PASS: TestAccIBMEventStreamsTopicDataSourceBasic (220.34s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/eventstreams	222.988s

% make testacc TEST=./ibm/service/eventstreams TESTARGS='-run=TestAccIBMEventStreamsTopicResourceWithExistingInstance'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/eventstreams -v -run=TestAccIBMEventStreamsTopicResourceWithExistingInstance -timeout 700m
=== RUN   TestAccIBMEventStreamsTopicResourceWithExistingInstance
--- PASS: TestAccIBMEventStreamsTopicResourceWithExistingInstance (63.17s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/eventstreams	65.980s

% make testacc TEST=./ibm/service/eventstreams TESTARGS='-run=TestAccIBMEventStreamsTopicResourceBasic'               
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/eventstreams -v -run=TestAccIBMEventStreamsTopicResourceBasic -timeout 700m
=== RUN   TestAccIBMEventStreamsTopicResourceBasic
--- PASS: TestAccIBMEventStreamsTopicResourceBasic (77.67s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/eventstreams	80.384s

% make testacc TEST=./ibm/service/eventstreams TESTARGS='-run=TestAccIBMEventStreamsTopicImport'       
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/eventstreams -v -run=TestAccIBMEventStreamsTopicImport -timeout 700m
=== RUN   TestAccIBMEventStreamsTopicImport
--- PASS: TestAccIBMEventStreamsTopicImport (57.77s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/eventstreams	60.471s

% make testacc TEST=./ibm/service/eventstreams TESTARGS='-run=TestAccIBMEventStreamsSchemaDataSourceBasic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/eventstreams -v -run=TestAccIBMEventStreamsSchemaDataSourceBasic -timeout 700m
=== RUN   TestAccIBMEventStreamsSchemaDataSourceBasic
--- PASS: TestAccIBMEventStreamsSchemaDataSourceBasic (185.74s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/eventstreams	188.384s

% make testacc TEST=./ibm/service/eventstreams TESTARGS='-run=TestAccIBMEventStreamsSchemaBasic'          
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/eventstreams -v -run=TestAccIBMEventStreamsSchemaBasic -timeout 700m
=== RUN   TestAccIBMEventStreamsSchemaBasic
--- PASS: TestAccIBMEventStreamsSchemaBasic (74.48s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/eventstreams	77.159s


% make testacc TEST=./ibm/service/eventstreams TESTARGS='-run=TestAccIBMEventStreamsSchemaAllArgs'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/eventstreams -v -run=TestAccIBMEventStreamsSchemaAllArgs -timeout 700m
=== RUN   TestAccIBMEventStreamsSchemaAllArgs
--- PASS: TestAccIBMEventStreamsSchemaAllArgs (36.94s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/eventstreams	39.653s


% make testacc TEST=./ibm/service/eventstreams TESTARGS='-run=TestAccIBMEventStreamsSchemaImport' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/eventstreams -v -run=TestAccIBMEventStreamsSchemaImport -timeout 700m
=== RUN   TestAccIBMEventStreamsSchemaImport
--- PASS: TestAccIBMEventStreamsSchemaImport (43.85s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/eventstreams	46.520s

...

@kccox kccox changed the title Event Streams: update error diagnostic reporting in existing code fix: update error diagnostic reporting in existing Event Streams code Sep 25, 2024
@hkantare hkantare merged commit 605c84e into IBM-Cloud:master Sep 26, 2024
1 check passed
@kccox kccox deleted the update-errors-schema-topics branch September 26, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants