Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GRS attributes to pi_volume (d) and pi_instance_volumes (d) #5671

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

Alexander-Kita
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

pi_volume (d):

=== RUN   TestAccIBMPIVolumeDataSource_basic
--- PASS: TestAccIBMPIVolumeDataSource_basic (6.67s)
PASS
=== RUN   TestAccIBMPIVolumeDataSource_replication
--- PASS: TestAccIBMPIVolumeDataSource_replication (11.99s)
PASS

pi_instance_volumes (d):

=== RUN   TestAccIBMPIVolumesDataSource_basic
--- PASS: TestAccIBMPIVolumesDataSource_basic (18.04s)
PASS

Description:

Added replication_sites, creation_date, last_update_date, and freeze_time attributes to pi_instance_volumes and pi_volume data sources.

Added replication_enabled attribute to volumes returned by pi_instance_volumes data source.

@Alexander-Kita Alexander-Kita added the service/Power Systems Issues related to Power Systems label Sep 23, 2024
@Alexander-Kita
Copy link
Collaborator Author

@hkantare @yussufsh Please review for power Q3 release.

ismirlia
ismirlia previously approved these changes Sep 23, 2024
michaelkad
michaelkad previously approved these changes Oct 1, 2024
@Alexander-Kita Alexander-Kita force-pushed the add-gsr-attributes-volume-d branch from 76f1325 to 440835c Compare October 10, 2024 14:09
yussufsh
yussufsh previously approved these changes Oct 11, 2024
@yussufsh
Copy link
Collaborator

@Alexander-Kita please rebase.

@Alexander-Kita Alexander-Kita dismissed stale reviews from yussufsh, ismirlia, and michaelkad via b511a23 October 11, 2024 15:48
@Alexander-Kita Alexander-Kita force-pushed the add-gsr-attributes-volume-d branch from 440835c to b511a23 Compare October 11, 2024 15:48
@yussufsh yussufsh merged commit 999d73b into master Oct 11, 2024
1 check passed
@Alexander-Kita Alexander-Kita deleted the add-gsr-attributes-volume-d branch November 19, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants