-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update kms instance policies #5346
Conversation
…cia defaults and changed to Computed, when enabled is false, don't update any other attributes, updated resource docs to reflect not using enabled=false with any other attributes
Fix the conflicts |
Can you share test case execution results |
Need one scenario to be tested provision with old provider version . once it provisioned can you rerun plan with new code changes and make sure it doesn't show any diff |
Forward compatibility test case
|
I seem to have introduced a bug. Apparently, Computed values don't takes precedence over defaults for new resources. So for new instances provisioned, the non-specified attributes would use false as the bool, submit a PUT, then only do a GET after. This breaks new instances and so I will roll back to using defaults which should work the same way. This issue was not seen for any existing instances as Computed values would take priority. |
…e' into instancePolicyUpdate
Forward Compatibility Tests again below logs demonstrate disabling of kcia policy, drift when trying to specify extra attributes while disabled, successful apply with attributes when policy is enabled, no drift further as policy update was successful
|
@hkantare please take another look |
* use new go sdk for kms that uses pointers for policy bools, removed kcia defaults and changed to Computed, when enabled is false, don't update any other attributes, updated resource docs to reflect not using enabled=false with any other attributes * update networking go sdk version to resolve conflict * move back to using defaults --------- Co-authored-by: wsiew <wsiew@ibm.com>
… fix for [provider bug](IBM-Cloud/terraform-provider-ibm#5346)
use new go sdk for kms that uses pointers for policy bools,
removed kcia defaults and changed to Computed,
when enabled is false, don't update any other attributes,
updated resource docs to reflect not using enabled=false with any other attributes
#5342
Community Note
Relates OR Closes #0000
Output from acceptance testing: