Documentation for Openshift-Data-Foundation Add-on & VPC Worker Replace #4627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasan4791
suggested changes
Jun 17, 2023
| @@ -1,7 +1,7 @@ | |||
| terraform { | |||
| required_providers { | |||
| kubernetes = { | |||
| version = "2.18.1" | |||
| version = ">= 2.18.1" | |||
| } | |||
| ibm = { | |||
| source = "IBM-Cloud/ibm" | |||
There was a problem hiding this comment.
Update the IBM cloud provider version to the one where the support is added.
| ############################### | ||
|
|
||
| terraform { | ||
| required_version = ">=1.0.0, <2.0" |
There was a problem hiding this comment.
Update the IBM cloud provider version to the one where the support is added.
| default = "" | ||
| } | ||
|
|
||
| variable "check_ptx_status" { |
| default = null | ||
| } | ||
|
|
||
| variable "ptx_timeout" { |
5fcc3f2 to
4a7406d
Compare
review comments added reverted resource_addons.go deleteaddon.sh updated
4a7406d to
e0d4b4a
Compare
hasan4791
approved these changes
Jun 18, 2023
|
@hkantare PTAL |
hkantare
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples Terraform Templates for ODF add-on and worker replace
Community Note
Relates OR Closes #0000
Output from acceptance testing: